Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add targeted_imaging_depth column to get_ophys_experiment_table #2648

Merged
merged 4 commits into from
Jan 23, 2023
Merged

Add targeted_imaging_depth column to get_ophys_experiment_table #2648

merged 4 commits into from
Jan 23, 2023

Conversation

mikejhuang
Copy link
Contributor

No description provided.

@mikejhuang mikejhuang requested review from aamster and morriscb and removed request for aamster January 20, 2023 22:19
@mikejhuang
Copy link
Contributor Author

mikejhuang commented Jan 20, 2023 •
edited
Loading

Should we be running the notebook runner if there weren't any changes to the notebooks?

morriscb
morriscb requested changes Jan 20, 2023
View reviewed changes
Copy link
Contributor

@morriscb morriscb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. I'd recommend re-targeting this PR onto rc/2.15.0 instead of directly onto master.

@mikejhuang mikejhuang force-pushed the targeted_imaging_depth_to_oe_table branch from 3406ff6 to 5b7d1a8 Compare January 20, 2023 22:27
@mikejhuang mikejhuang changed the base branch from master to 2.15.0 January 20, 2023 22:27
@mikejhuang
Copy link
Contributor Author

mikejhuang commented Jan 20, 2023 •
edited
Loading

Should we be running the notebook runner if there weren't any changes to the notebooks?

I made a change to the notebook runner to only run if there are changes in the path 'doc_template/examples_root/examples/nb/**'

edit: nevermind, this check is still needed even if the notebooks aren't changed. I reverted that commit.

@mikejhuang mikejhuang force-pushed the targeted_imaging_depth_to_oe_table branch from 5b7d1a8 to 2f16eae Compare January 20, 2023 22:33
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@CLAassistant
Copy link

CLAassistant commented Jan 20, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@mikejhuang mikejhuang changed the base branch from 2.15.0 to rc/2.15.0 January 20, 2023 22:34
@mikejhuang mikejhuang force-pushed the targeted_imaging_depth_to_oe_table branch 2 times, most recently from 819b30b to 7ef58c1 Compare January 20, 2023 22:42
@mikejhuang mikejhuang merged commit 045ec3c into rc/2.15.0 Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morriscb morriscb morriscb approved these changes

@aamster aamster Awaiting requested review from aamster

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikejhuang @CLAassistant @morriscb